[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi added a comment.

I have a fix. About to push.

In D70274#1754306 <https://reviews.llvm.org/D70274#1754306>, @leonardchan wrote:

> Hi! I think this patch might be causing some test failures on our mac bots:
>
>   FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220)
>   ******************** TEST 'Clang :: InterfaceStubs/merge-conflict-test.c' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';   not /b/s/w/ir/k/recipe_cleanup/clangKJGdzA/llvm_build_dir/bin/clang -fvisibility=default -o libfoo.so -emit-interface-stubs /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/merge-conflict-test.c /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/driver-test.c 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangKJGdzA/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/merge-conflict-test.c
>   --
>   Exit Code: 1
>  
>   Command Output (stderr):
>   --
>   /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/merge-conflict-test.c:2:11: error: CHECK: expected string not found in input
>   // CHECK: error: Interface Stub: Type Mismatch
>             ^
>   <stdin>:1:1: note: scanning from here
>   clang-10: error: cannot specify -o when generating multiple output files
>   ^
>   <stdin>:1:11: note: possible intended match here
>   clang-10: error: cannot specify -o when generating multiple output files
>             ^
>  
>   --
>  
>   ********************
>   Testing:  0.. 10.. 20.. 30..
>   FAIL: Clang :: InterfaceStubs/object-float.c (6276 of 16220)
>   ******************** TEST 'Clang :: InterfaceStubs/object-float.c' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 1';   not /b/s/w/ir/k/recipe_cleanup/clangKJGdzA/llvm_build_dir/bin/clang -fvisibility=default -o - -emit-interface-stubs /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/object-float.c /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/object.c 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangKJGdzA/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/object-float.c
>   --
>   Exit Code: 1
>  
>   Command Output (stderr):
>   --
>   /b/s/w/ir/k/llvm-project/clang/test/InterfaceStubs/object-float.c:2:11: error: CHECK: expected string not found in input
>   // CHECK: error: Interface Stub: Size Mismatch
>             ^
>   <stdin>:1:1: note: scanning from here
>   clang-10: error: cannot specify -o when generating multiple output files
>   ^
>   <stdin>:1:11: note: possible intended match here
>   clang-10: error: cannot specify -o when generating multiple output files
>             ^
>  
>   --
>  
>   ********************
>   Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
>  
>   Testing Time: 131.42s
>   ********************
>   Failing Tests (2):
>       Clang :: InterfaceStubs/merge-conflict-test.c
>       Clang :: InterfaceStubs/object-float.c
>
>
> Could you look into it? Thanks.
>
> Bot link: https://ci.chromium.org/p/fuchsia/builders/ci/clang-mac-x64/b8896234755488932160





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70274/new/

https://reviews.llvm.org/D70274