[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 19 18:05:10 PST 2019


dexonsmith added a comment.

For some reason this revision is locked down and I'm not allowed to "edit" it, which includes adding inline review comments.  Can you add me as a reviewer?

The two comments:

- Please add a period at the end of the sentence in the comment.
- Can you give more context about what `objc_arc_inert` is doing, and why it's necessary now that `no_dead_strip` is gone?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70284/new/

https://reviews.llvm.org/D70284





More information about the cfe-commits mailing list