[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

Marcin Twardak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 19 11:29:30 PST 2019


twardakm updated this revision to Diff 230113.
twardakm added a comment.

Apply Aaron's comments

- Fix missing namespace to macro definition instead of extension
- Print macro definition also in warning message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69855/new/

https://reviews.llvm.org/D69855

Files:
  clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
  clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.h
  clang-tools-extra/test/clang-tidy/checkers/google-readability-namespace-comments.cpp
  clang-tools-extra/test/clang-tidy/checkers/llvm-namespace-comment.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69855.230113.patch
Type: text/x-patch
Size: 11839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191119/724c1d67/attachment.bin>


More information about the cfe-commits mailing list