[PATCH] D69598: Work on cleaning up denormal mode handling

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D69598#1742740 <https://reviews.llvm.org/D69598#1742740>, @andrew.w.kaylor wrote:

> Thanks. I understand your direction for denormal handling now, and I'm OK with this patch apart from the remaining references to subnormal that Sanjay mentioned.
>
> In D69598#1739723 <https://reviews.llvm.org/D69598#1739723>, @arsenm wrote:
>
> > I do think the floating point environment bits should be a considered a property of the calling convention, with attributes that override them. A function which calls a function with a different mode would be responsible for switching the mode before the call. This would require people actually caring about getting this right to really implement
>
>
> Do you mean the compiler should insert code to restore the FP environment on function transitions?


When calling a convention with a different FP mode, yes. For example graphics shaders have a different default FP mode than compute functions. Theoretically a graphics shader could link a compute function library, which would require switching the mode around the call. My consideration isn't really for users using FENV_ACCESS


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69598/new/

https://reviews.llvm.org/D69598