[PATCH] D70183: Detect source location overflow due includes
Mikhail Maltsev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 19 06:43:19 PST 2019
miyuki requested changes to this revision.
miyuki added a comment.
This revision now requires changes to proceed.
This essentially means that if there is a problem related to this change, say something goes wrong after `return FileID();` it would be impossible to debug until the corresponding assertions are fixed. Also the patch lacks tests (and adding a test is impossible because it would fail in debug builds).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70183/new/
https://reviews.llvm.org/D70183
More information about the cfe-commits
mailing list