[clang-tools-extra] f0021f9 - [clangd] Fix ps4 buildbot failure.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 19 01:42:50 PST 2019


Author: Haojian Wu
Date: 2019-11-19T10:42:27+01:00
New Revision: f0021f95a1f40369e30bb94be1b0322747631047

URL: https://github.com/llvm/llvm-project/commit/f0021f95a1f40369e30bb94be1b0322747631047
DIFF: https://github.com/llvm/llvm-project/commit/f0021f95a1f40369e30bb94be1b0322747631047.diff

LOG: [clangd] Fix ps4 buildbot failure.

dynamic_cast on ps4 buildbot seems relying on rtti flag which is off by
default. Remove the dynamic_cast in the tests.

Added: 
    

Modified: 
    clang-tools-extra/clangd/unittests/RenameTests.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/unittests/RenameTests.cpp b/clang-tools-extra/clangd/unittests/RenameTests.cpp
index b7678f1d5fe4..8dedcf579fd3 100644
--- a/clang-tools-extra/clangd/unittests/RenameTests.cpp
+++ b/clang-tools-extra/clangd/unittests/RenameTests.cpp
@@ -210,8 +210,6 @@ TEST(RenameTest, WithinFileRename) {
           [[Foo]] foo;
           const Baz &BazReference = foo;
           const Baz *BazPointer = &foo;
-          dynamic_cast<const [[^Foo]] &>(BazReference).getValue();
-          dynamic_cast<const [[^Foo]] *>(BazPointer)->getValue();
           reinterpret_cast<const [[^Foo]] *>(BazPointer)->getValue();
           static_cast<const [[^Foo]] &>(BazReference).getValue();
           static_cast<const [[^Foo]] *>(BazPointer)->getValue();


        


More information about the cfe-commits mailing list