[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/Driver.cpp:3491
+  if (Arg *A = Args.getLastArg(options::OPT_emit_interface_stubs)) {
+
+    llvm::SmallVector<phases::ID, phases::MaxNumberOfPhases> PhaseList;
----------------
Extraneous whitespace


================
Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:37
+  if (OutputFilename != "-") {
+    if (llvm::sys::path::extension(OutputFilename) == ".so")
+      llvm::sys::path::replace_extension(OutputFilename,
----------------
Is there a way to check if the extension is a shared library extension, or better yet, check for the output type


================
Comment at: clang/test/InterfaceStubs/driver-test.c:4
+// RUN: %clang -target x86_64-unknown-linux-gnu -x c -o %t1 -emit-interface-stubs %s %S/object.c %S/weak.cpp
+// RUN: llvm-nm %t1   2>&1 | FileCheck %s
+// RUN: llvm-nm %t1.ifso 2>&1 | FileCheck %s
----------------
Unnecessary whitespace change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70274/new/

https://reviews.llvm.org/D70274