[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 18 13:15:45 PST 2019
sammccall added a comment.
In D70325#1749432 <https://reviews.llvm.org/D70325#1749432>, @kadircet wrote:
> LGTM, with a question. What about default template params? I believe we would also like to print them, could you add a test case for that?
They're not printed, as the type is "as written". Added a testcase and a FIXME.
(I don't think this case is terribly important - either behavior seems to have its advantages, the combination of default parameters and partial specialization is fairly rare, and not much confusion seems likely in practice)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70325/new/
https://reviews.llvm.org/D70325
More information about the cfe-commits
mailing list