[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 18 06:58:30 PST 2019


sammccall added a comment.

I'm reverting because this breaks ABI for llvm-c (and the go bindings).
Feel free to reapply with that change removed, though. (If this option is required for the C API, I'm not sure what the best approach is)



================
Comment at: llvm/include/llvm-c/DebugInfo.h:878
                            LLVMMetadataRef File, unsigned LineNo,
-                           LLVMMetadataRef Scope);
+                           LLVMMetadataRef Scope, uint32_t AlignInBits);
 
----------------
These functions in llvm-c are ABI-stable AFAIK.
(This broke the go bindings which are in-tree, but could equally break out-of-tree bindings)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70111/new/

https://reviews.llvm.org/D70111





More information about the cfe-commits mailing list