[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Mon Nov 18 06:58:29 PST 2019

dankm marked an inline comment as done.
dankm added inline comments.

================
Comment at: clang/test/Driver/debug-prefix-map.c:8
+// RUN: %clang -### -ffile-prefix-map=old=new %s 2>&1 | FileCheck %s -check-prefix CHECK-DEBUG-SIMPLE
+// RUN: %clang -### -ffile-prefix-map=old=new %s 2>&1 | FileCheck %s -check-prefix CHECK-MACRO-SIMPLE
+
----------------
Lekensteyn wrote:
> What about combining these two tests? The command is the same, maybe you could have a new `-check-prefix` to reduce the number of invocations? Likewise for the cases below.
The tests will need more thinking, you're probably right, but I don't have much time to work on this at the moment. How do you feel about addressing this in the future?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49466/new/

https://reviews.llvm.org/D49466