[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 18 06:30:55 PST 2019


JonasToth added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:47
+    std::vector<int>&& obj = ...;
+    return std::move(obj);  // calls StatusOr::StatusOr(std::vector<int>&&)
+  }
----------------
While checking this example it seems clang already has a warning for that case?

https://godbolt.org/z/q5zzh-

What parts of this check will be more then the warnings already do?


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-no-automatic-move.rst:55
+
+## Semantics
+
----------------
Does this syntax work in rst files?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70390/new/

https://reviews.llvm.org/D70390





More information about the cfe-commits mailing list