[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 18 05:54:43 PST 2019


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:371
     auto TU = TestTU::withCode(Code.code());
+    TU.AdditionalFiles["foo.inc"] = R"cpp(
+      #define Macro(X) X
----------------
ilya-biryukov wrote:
> Maybe test this separately? It's only used in one test.
> Having this added for all tests cases is somewhat confusing.
moved to a separate test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69934/new/

https://reviews.llvm.org/D69934





More information about the cfe-commits mailing list