[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

[liu hui via Phabricator via cfe-commits]

lh123 added a comment.

In D70222#1749533 <https://reviews.llvm.org/D70222#1749533>, @kadircet wrote:

> Thanks for taking a look into this, the `rsp files` issue has came up before in the past but there wasn't enough investment to implement it.
>
> Haven't checked the implementation in detail yet, I believe the layering should be different;
>
> This is a common problem for all of the clang-related tools, as they all share the same "compilation database" abstraction layer, therefore it would be better to implement this at that layer so that other tools (e.g, clang-tidy) can also benefit from this.
>  You can find the related code in `clang/include/clang/Tooling/CompilationDatabase.h` and `clang/lib/Tooling/CompilationDatabase.cpp`.
>
> Also compilation databases has been historically neglecting `Virtual File System` abstractions, it is hard to change it now. But would be great if you could try to keep that in mind while performing reads.
>
> So would you mind making such changes ?




In D70222#1749533 <https://reviews.llvm.org/D70222#1749533>, @kadircet wrote:

> Thanks for taking a look into this, the `rsp files` issue has came up before in the past but there wasn't enough investment to implement it.
>
> Haven't checked the implementation in detail yet, I believe the layering should be different;
>
> This is a common problem for all of the clang-related tools, as they all share the same "compilation database" abstraction layer, therefore it would be better to implement this at that layer so that other tools (e.g, clang-tidy) can also benefit from this.
>  You can find the related code in `clang/include/clang/Tooling/CompilationDatabase.h` and `clang/lib/Tooling/CompilationDatabase.cpp`.
>
> Also compilation databases has been historically neglecting `Virtual File System` abstractions, it is hard to change it now. But would be great if you could try to keep that in mind while performing reads.
>
> So would you mind making such changes ?


Ok, I will look into this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70222/new/

https://reviews.llvm.org/D70222