[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.h:128
+struct References {
+  std::vector<Location> Refs; // reference locations of the symbol.
+  bool InComplete = false;    // true if the result is incomplete.
----------------
References -> ReferenceList or ReferencesResult, and Refs -> References?

calling the struct References seems unclear, and takes away the useful unabbreviated variable name


================
Comment at: clang-tools-extra/clangd/XRefs.h:128
+struct References {
+  std::vector<Location> Refs; // reference locations of the symbol.
+  bool InComplete = false;    // true if the result is incomplete.
----------------
sammccall wrote:
> References -> ReferenceList or ReferencesResult, and Refs -> References?
> 
> calling the struct References seems unclear, and takes away the useful unabbreviated variable name
these comments don't seem to add much - remove?


================
Comment at: clang-tools-extra/clangd/XRefs.h:129
+  std::vector<Location> Refs; // reference locations of the symbol.
+  bool InComplete = false;    // true if the result is incomplete.
+};
----------------
we call this `HasMore` in code complete.

(incomplete is one word)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70380/new/

https://reviews.llvm.org/D70380