[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

[Sam McCall via Phabricator via cfe-commits]

sammccall added subscribers: ilya-biryukov, sammccall.
sammccall added a comment.

This seems to have broken clangd tests e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/58189/steps/test-check-all/logs/stdio

FindExplicitReferences now finds duplicate refs to `vector` in

               void foo() {
  -              for (int $0^x : $1^vector()) {
  -                $2^x = 10;
  +              for (int $0^x : $1^$2^vector()) {
  +                $3^x = 10;
                 }
               }

`ninja check-clangd`, or `ninja ClangdTests && tools/clang/tools/extra/clangd/unittests/ClangdTests --gtest_filter=FindExplicitReferencesTest.All`

I don't have much context on this code, @ilya-biryukov may be able to advise next week


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69360/new/

https://reviews.llvm.org/D69360