[clang-tools-extra] a7f97b0 - [clangd] Improve long and confusing preamble log message.
Sam McCall via cfe-commits
cfe-commits at lists.llvm.org
Sat Nov 16 08:16:46 PST 2019
Author: Sam McCall
Date: 2019-11-16T17:13:02+01:00
New Revision: a7f97b02b4fa8b4b1824a7c9b14deb798f55e76a
URL: https://github.com/llvm/llvm-project/commit/a7f97b02b4fa8b4b1824a7c9b14deb798f55e76a
DIFF: https://github.com/llvm/llvm-project/commit/a7f97b02b4fa8b4b1824a7c9b14deb798f55e76a.diff
LOG: [clangd] Improve long and confusing preamble log message.
Added:
Modified:
clang-tools-extra/clangd/Preamble.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clangd/Preamble.cpp b/clang-tools-extra/clangd/Preamble.cpp
index 41e3c1368eb7..eca545fd09e4 100644
--- a/clang-tools-extra/clangd/Preamble.cpp
+++ b/clang-tools-extra/clangd/Preamble.cpp
@@ -102,10 +102,11 @@ buildPreamble(PathRef FileName, CompilerInvocation &CI,
compileCommandsAreEqual(Inputs.CompileCommand, OldCompileCommand) &&
OldPreamble->Preamble.CanReuse(CI, ContentsBuffer.get(), Bounds,
Inputs.FS.get())) {
- vlog("Reusing preamble for file {0}", llvm::Twine(FileName));
+ vlog("Reusing preamble for {0}", FileName);
return OldPreamble;
}
- vlog("Preamble for file {0} cannot be reused. Attempting to rebuild it.",
+ vlog(OldPreamble ? "Rebuilding invalidated preamble for {0}"
+ : "Building first preamble for {0}",
FileName);
trace::Span Tracer("BuildPreamble");
More information about the cfe-commits
mailing list