[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 16 05:05:11 PST 2019


Eugene.Zelenko added a comment.

General comments:

- Isn't //Option(s) ... was/were added// or //Option(s) ... had been added// are more correct from from point of view of English grammar? Same for older entries.
- It'll be great to nag developers to expand Release Notes when relevant code changes are made.



================
Comment at: clang/docs/ReleaseNotes.rst:322
 
+- Options and ``DeriveLineEnding`` and  ``UseCRLF`` added to allow 
+  clang-format to control the newlines, ``DeriveLineEnding`` is by default 
----------------
and between Options and DeriveLineEnding are not necessary.


================
Comment at: clang/docs/ReleaseNotes.rst:323
+- Options and ``DeriveLineEnding`` and  ``UseCRLF`` added to allow 
+  clang-format to control the newlines, ``DeriveLineEnding`` is by default 
+  ``true`` and reflects is the existing mechanism, which based is on majority
----------------
I would suggest to use dot after newlines.


================
Comment at: clang/docs/ReleaseNotes.rst:325
+  ``true`` and reflects is the existing mechanism, which based is on majority
+  rule. The new options allows this to be turned off and UseCRLF to control 
+  the decision as to which sort of line ending to use.
----------------
UseCRLF should be enclosed in double back-ticks.


================
Comment at: clang/docs/ReleaseNotes.rst:328
+
+- Option ``SpaceBeforeSquareBrackets`` added to allow for a space before
+  array declarations.
----------------
to //insert//?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70355/new/

https://reviews.llvm.org/D70355





More information about the cfe-commits mailing list