[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11247
+    RHSIsSubsetOfLHS = true;
+  } else {
+    for (const OMPContextSelectorData &Data : LHS) {
----------------
Nit: `bool RHSIsSubsetOfLHS = isStrictSubset(RHS, LHS)`
saves you a line later.


================
Comment at: clang/test/OpenMP/declare_variant_device_kind_codegen.cpp:81
+#define SUBSET host, cpu
+#define WRONG cpu, gpu
+#endif // CPU
----------------
What is wrong about cpu, gpu together?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70245/new/

https://reviews.llvm.org/D70245