[PATCH] D70348: Add header guards for header files that should not be included on the PS4 platform
Douglas Yung via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 15 18:11:00 PST 2019
dyung added a comment.
In D70348#1748580 <https://reviews.llvm.org/D70348#1748580>, @craig.topper wrote:
> You could probably just define add __ORBIS__ to every line and then rely on the individual feature defines at the end of the line to re-enable the ones that are really supported. I assume the target-cpu is set to btver for ps4?
Good point. I talked it over internally with a few other people and think this is a good way to go. I'll revise and upload a new patch later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70348/new/
https://reviews.llvm.org/D70348
More information about the cfe-commits
mailing list