[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:357
+
+  if (ConstrainedIntrinsicID != Intrinsic::not_intrinsic &&
+      CGF.Builder.getIsFPConstrained()) {
----------------
I don't see any situation where `not_intrinsic` is passed in here; why all these checks?


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2302
+      return RValue::get(Builder.CreateCall(F, {Base, Exponent}));
+    }
   }
----------------
What can this not use the standard path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70256/new/

https://reviews.llvm.org/D70256