[PATCH] D69620: Add AIX assembler support

Steven Wan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 15 10:50:18 PST 2019


stevewan marked an inline comment as done.
stevewan added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.h:26
+
+  bool hasIntegratedCPP() const override { return false; }
+
----------------
Xiangling_L wrote:
> I saw a lot of other target also set `hasIntegratedCPP()` as false, but I didn't find any explanation in documentation, so I am curious that what this is about?
I also failed to find useful resources that explains the purpose of this function. The main rationales of adding it were essentially that,
1. It's a pure virtual function in the base `Tool` class,
2. Most if not all of other targets had overridden this function such that it returns false.

I'll leave this comment open, and see if someone could enlighten us. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69620/new/

https://reviews.llvm.org/D69620





More information about the cfe-commits mailing list