[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 15 09:38:44 PST 2019


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with one change to DIBuilder inline.



================
Comment at: llvm/include/llvm/IR/DIBuilder.h:243
+                                 unsigned LineNo, DIScope *Context,
+                                 Optional<unsigned> AlignInBits);
 
----------------
This can still be `Optional<unsigned> AlignInBits = {}` to avoid churn.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70111/new/

https://reviews.llvm.org/D70111





More information about the cfe-commits mailing list