[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

[Haojian Wu via Phabricator via cfe-commits]

hokein updated this revision to Diff 229530.
hokein marked 6 inline comments as done.
hokein added a comment.

address review comments:

- don't rename inside macro body
- fixed a corner case where the rename occurrence may come from a non-preamble #include
- add more tests, and simplify the testcases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69934/new/

https://reviews.llvm.org/D69934

Files:
  clang-tools-extra/clangd/refactor/Rename.cpp
  clang-tools-extra/clangd/unittests/RenameTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69934.229530.patch
Type: text/x-patch
Size: 18752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191115/5f14f746/attachment-0001.bin>