[PATCH] D70299: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 15 05:27:59 PST 2019
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:181
TEST_F(WorkspaceSymbolsTest, AnonymousNamespace) {
- addFile("foo.h", R"cpp(
+ // header symbols in anonymous namespace are not collected.
+ addFile("foo.cpp", R"cpp(
----------------
I'm not sure what the purpose of this comment is (in reference to the code, rather than to this change) - just remove it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70299/new/
https://reviews.llvm.org/D70299
More information about the cfe-commits
mailing list