[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

[Chi Chun Chen via Phabricator via cfe-commits]

cchen marked an inline comment as done.
cchen added inline comments.


================
Comment at: clang/test/OpenMP/target_defaultmap_codegen.cpp:1538-1546
+void declare_target_link(float A)
+{
+  // CK26: [[AADDR:%.+]] = alloca float*
+  // CK26: store float* [[A:%.+]], float** [[AADDR]]
+  // CK26: [[ZERO:%.+]] = load float*, float** [[AADDR]]
+  // CK26: [[ONE:%.+]] = load float, float* [[ZERO]]
+#pragma omp target defaultmap(none:aggregate) map(A)
----------------
ABataev wrote:
> What does this test check? It is not the test for declare target link. Also, A is calar and defaultmap is for aggregates.
My bad, I forgot to update from target to(Vector) to target link(Vector). And my intention for the aggregate is for Vector[1024] not for A. The confusion is due to my negligence, I'll fix it right away. Thanks for your passion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69204/new/

https://reviews.llvm.org/D69204