[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

Thu Nov 14 13:29:41 PST 2019

poelmanc marked an inline comment as not done.
poelmanc added a comment.

In D67460#1737529 <https://reviews.llvm.org/D67460#1737529>, @aaron.ballman wrote:

> I'm a bit worried that this manual parsing technique will need fixing again in the future, but I think this is at least a reasonable incremental improvement.

Thanks and I agree. Your comments encouraged me to take another stab at improving things. See D70270 <https://reviews.llvm.org/D70270>, a whole new approach that removes manual parsing in favor of AST processing and successfully converts many more cases from `typedef` to `using`.

I didn't want to clobber this patch with that one in case any fatal flaws are discovered with the new approach. We can commit this one first - getting improved handling of commas and getting additional test cases - and treat D70270 <https://reviews.llvm.org/D70270> as that next incremental improvement. Or we can keep this on hold until D70270 <https://reviews.llvm.org/D70270> is worked out.

Thanks again for all your feedback and help!

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67460/new/

https://reviews.llvm.org/D67460