[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D69759#1746192 <https://reviews.llvm.org/D69759#1746192>, @yonghong-song wrote:

> Sorry about the committing. I thought all the review questions are addressed.


No worries, this happens sometimes. :-)

> Definitely will be more patient next time until getting review confirmation and
>  also adhering to llvm review policy.

Thanks!

> Thanks for the detailed review! I have addressed all of your review comments in patch
>  https://reviews.llvm.org/D70257. I have added you as the reviewer.

Fantastic, thank you!



================
Comment at: clang/lib/CodeGen/CGExpr.cpp:3440-3443
+    while (TypedefT) {
+      PointeeT = TypedefT->desugar().getTypePtr();
+      TypedefT = dyn_cast<TypedefType>(PointeeT);
+    }
----------------
yonghong-song wrote:
> aaron.ballman wrote:
> > Is there a reason you only want to strip off typedefs, and not other forms of sugar? e.g., why not call `getUnqualifiedDesugaredType()`?
> Actually, ElaboratedT is also a sugar type, the above getUnqualifiedDesugaredType() will remove it too.
Yes, but you just strip off that sugar anyway, so that's why I suggested this. It seems you got the gist of my suggestion in the other review though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69759/new/

https://reviews.llvm.org/D69759