[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

Thu Nov 14 11:02:03 PST 2019

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.

================
Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:200
+OpenMPIRBuilder::InsertPointTy
+OpenMPIRBuilder::emitBarrierImpl(const LocationDescription &Loc, Directive Kind,
+                                 bool ForceSimpleCall, bool CheckCancelFlag) {
----------------
ABataev wrote:
> Maybe split emission ща `__kmpc_barrier` and `__kmpc_cancel_barrier` functions into 2 independent functions fo the frontends? Rather than rely on the boolean flags?
The frontend doesn't know necessarily when a barrier is issued if it is a cancellable, arguably it shouldn't need to know at all

I copied the flags from clang but I will look into removing them eventually (and to add a TODO in the meantime).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785