[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

This is a single .rc entry:

  {
    "directory": "C:/src/llvm-project/build",
    "command": "C:\\PROGRA~2\\WI3CF2~1\\10\\bin\\100183~1.0\\x64\\rc.exe -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_
  DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__
  STDC_LIMIT_MACROS -DRC_FILE_VERSION=\\\"10.0.0git\\\" -DRC_INTERNAL_NAME=\\\"llvm-tblgen\\\" -DRC_PRODUCT_NAME=\\\"LLVM\\\" -DRC_PRODUCT_VERSION=\\\"10.0.0git\\\" -DRC_VERS
  ION_FIELD_1=10 -DRC_VERSION_FIELD_2=0 -DRC_VERSION_FIELD_3=0 -DRC_VERSION_FIELD_4=0 -IC:\\src\\llvm-project\\build\\utils\\TableGen -IC:\\src\\llvm-project\\llvm\\utils\\Ta
  bleGen -IC:\\src\\llvm-project\\build\\include -IC:\\src\\llvm-project\\llvm\\include  /DWIN32   -UNDEBUG /nologo /foutils\\TableGen\\CMakeFiles\\llvm-tblgen.dir\\__\\__\\r
  esources\\windows_version_resource.rc.res C:\\src\\llvm-project\\llvm\\resources\\windows_version_resource.rc",
    "file": "C:/src/llvm-project/llvm/resources/windows_version_resource.rc"
  },

There is one for every binary. I think .rc files can include headers to get things like struct sizes and macros. My understanding is that it's an old fork of the Visual C compiler, so it is in some sense a "compilation". I suppose if you wanted to write a global renaming tool for a macro, you'd need to know about uses in .rc files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70196/new/

https://reviews.llvm.org/D70196