[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

Pierre Habouzit via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 22:00:16 PST 2019


MadCoder added a comment.

In D69991#1744979 <https://reviews.llvm.org/D69991#1744979>, @aprantl wrote:

> Is it intentional that the direct method names use the exact same symbol namespace (`\01-[class message]`) as "real" Objective-C methods? Could that be a problem? Should we use a slightly different naming scheme?


I don't have an answer here, real compiler folks should answer (ping @rjmccall ?).

Two statements:

- I would desire for the backtraces in a crash report to still look similar so moving to `_-[class message]` (with the leading `_`) would be fine
- the name can't quite collide because you can't define this symbol as both direct and dynamic, so it's effectively always free

I can however see why it may or may not confuse the debugger


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69991/new/

https://reviews.llvm.org/D69991





More information about the cfe-commits mailing list