[PATCH] D70157: Align branches within 32-Byte boundary

Wed Nov 13 20:47:16 PST 2019

skan marked an inline comment as done.
skan added inline comments.

================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:88
+    SmallVector<StringRef, 6> BranchTypes;
+    StringRef(Val).split(BranchTypes, '-', -1, false);
+    for (auto BranchType : BranchTypes) {
----------------
craig.topper wrote:
> skan wrote:
> > craig.topper wrote:
> > > skan wrote:
> > > > chandlerc wrote:
> > > > > I feel like a comma-separated list would be a bit more clear...
> > > > We can't use comma-separated list because we need pass the option with flto.  "-Wl,-plugin-opt=--x86-align-branch-boundary=32,--plugin-opt=-x86-align-branch=fused,jcc,jmp,--plugin-opt=-x86-align-branch-prefix-size=5" would cause a compile fail because "jcc" was recognized as another option rather than a part of option "-x86-align-branch=fused,jcc,jmp" 
> > > Isn't there some way to nest quotes into the part of after -plugin-opt= ?
> > I tried to use --plugin-opt=-x86-align-branch="fused,jcc,jmp", it didn't work.
> What if you put —plugin-opt=“-x86-align-branch=fused,jcc,jmp”
It doesn't work too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70157/new/

https://reviews.llvm.org/D70157