[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

[Vedant Kumar via Phabricator via cfe-commits]

vsk updated this revision to Diff 229215.
vsk added a comment.

Don't emit declaration subprograms for functions with reserved names. There may not be much benefit from referencing these functions from call site tags (e.g. instead of relying on call site info to work out the arguments passed to __asan_memcpy, the asan runtime could log those arguments instead).

This fixes a verifier failure:

  inlinable function call in a function with debug info must have a !dbg location
    %134 = call i8* @__asan_memcpy(i8* %agg.tmp2.sroa.0.0..sroa_cast10.i, i8* %agg.tmp.sroa.0.i.0..sroa_cast, i64 32)

@aprantl / @djtodoro, mind taking another look?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69970/new/

https://reviews.llvm.org/D69970

Files:
  clang/include/clang/Basic/IdentifierTable.h
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/Sema/SemaCodeComplete.cpp
  clang/test/CodeGen/debug-info-extern-call.c
  clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp
  llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69970.229215.patch
Type: text/x-patch
Size: 8527 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191114/8084c1e1/attachment-0001.bin>