[PATCH] D69958: Improve VFS compatibility on Windows

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

There is one issue with a comment, apart of that everything looks good to me. Looked into replacing slash and backslash literals with calls to `llvm::sys::path::get_separator` or `llvm::sys::path::is_separator` but in my attempts failed to improve existing patch.



================
Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:535
 /// All configuration options are optional.
 ///   'case-sensitive': <boolean, default=true>
 ///   'use-external-names': <boolean, default=true>
----------------
I believe changing default `CaseSensitive` value makes this comment incorrect. Have no strong opinion on making case-insensitive default on Windows because a better requirement is for VFS generators to specify 'case-sensitive' explicitly instead of relying on default values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69958/new/

https://reviews.llvm.org/D69958