[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 13 14:41:00 PST 2019
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
This is part of https://github.com/clangd/clangd/issues/180.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70209
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/clangd/unittests/XRefsTests.cpp
Index: clang-tools-extra/clangd/unittests/XRefsTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/XRefsTests.cpp
+++ clang-tools-extra/clangd/unittests/XRefsTests.cpp
@@ -981,6 +981,16 @@
HI.NamespaceScope = "";
HI.Value = "3";
}},
+ {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp",
+ [](HoverInfo &HI) {
+ HI.Name = "GREEN";
+ HI.NamespaceScope = "";
+ HI.LocalScope = "Color::";
+ HI.Definition = "GREEN";
+ HI.Kind = SymbolKind::EnumMember;
+ HI.Type = "enum Color";
+ HI.Value = "1";
+ }},
// FIXME: We should use the Decl referenced, even if it comes from an
// implicit instantiation.
{R"cpp(
Index: clang-tools-extra/clangd/XRefs.cpp
===================================================================
--- clang-tools-extra/clangd/XRefs.cpp
+++ clang-tools-extra/clangd/XRefs.cpp
@@ -657,6 +657,10 @@
Init->getType());
}
}
+ } else if (const auto *ECD = dyn_cast<EnumConstantDecl>(D)) {
+ // Dependent enums (e.g. nested in template classes) don't have values yet.
+ if (!ECD->getType()->isDependentType())
+ HI.Value = ECD->getInitVal().toString(10);
}
HI.Definition = printDefinition(D);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70209.229191.patch
Type: text/x-patch
Size: 1346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191113/a47c30e0/attachment.bin>
More information about the cfe-commits
mailing list