[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

Wed Nov 13 13:56:29 PST 2019

jfb added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5457
       // for AArch64, emit a warning and ignore the flag. Otherwise, add the
       // proper mllvm flags.
+      if (Triple.getArch() != llvm::Triple::aarch64 &&
----------------
t.p.northover wrote:
> jfb wrote:
> > The comment isn't quite right anymore. Maybe don't say `AArch64` since the code is obvious about what it checks?
> AArch64 is the official name of the 64-bit execution mode of ARM processors so I think it's still correct to say aarch64_32 is AArch64. Or were you referring to some other aspect of the comment?
It doesn't check the `be` variant. The comment is redundant anyways.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63131/new/

https://reviews.llvm.org/D63131