[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

Wed Nov 13 11:47:49 PST 2019

leonardchan added a comment.

Hi. I think this patch is causing some test failures for us:

  FAIL: Clang :: Driver/riscv64-toolchain.c (5479 of 16161)
  ******************** TEST 'Clang :: Driver/riscv64-toolchain.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes -target riscv64 2>&1 | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=CC1 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 6';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes    -target riscv64-unknown-elf    --gcc-toolchain=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree    --sysroot=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=C-RV64-BAREMETAL-LP64 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 22';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes    -target riscv64-unknown-elf    --sysroot=    --gcc-toolchain=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=C-RV64-BAREMETAL-NOSYSROOT-LP64 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 37';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang --driver-mode=g++ /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes    -target riscv64-unknown-elf -stdlib=libstdc++    --gcc-toolchain=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree    --sysroot=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=CXX-RV64-BAREMETAL-LP64 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 54';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang --driver-mode=g++ /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes    -target riscv64-unknown-elf -stdlib=libstdc++    --sysroot=    --gcc-toolchain=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=CXX-RV64-BAREMETAL-NOSYSROOT-LP64 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 70';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes -fuse-ld=ld    -target riscv64-unknown-linux-gnu -mabi=lp64    --gcc-toolchain=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk    --sysroot=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=C-RV64-LINUX-MULTI-LP64 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 86';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -### -no-canonical-prefixes -fuse-ld=ld    -target riscv64-unknown-linux-gnu -march=rv64imafd    --gcc-toolchain=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk    --sysroot=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck -check-prefix=C-RV64-LINUX-MULTI-LP64D /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  : 'RUN: at line 102';   /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/clang -target riscv64 /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c -emit-llvm -S -o - | /b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c
  --
  Exit Code: 1

  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/Driver/riscv64-toolchain.c:16:27: error: C-RV64-BAREMETAL-LP64: expected string not found in input
  // C-RV64-BAREMETAL-LP64: "{{.*}}/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1{{/|\\\\}}crtbegin.o"
                            ^
  <stdin>:6:349: note: scanning from here
   "/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1/../../../../bin/riscv64-unknown-elf-ld" "--sysroot=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf" "/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf/lib/crt0.o" "/b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/lib/clang/10.0.0/lib/clang_rt.crtbegin-riscv64.o" "-L/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf/lib" "-L/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1" "/b/s/w/ir/tmp/t/riscv64-toolchain-ae7410.o" "--start-group" "-lc" "-lgloss" "--end-group" "/b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/lib/clang/10.0.0/lib/libclang_rt.builtins-riscv64.a" "/b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/lib/clang/10.0.0/lib/clang_rt.crtend-riscv64.o" "-o" "a.out"
                                                                                                                                                                                                                                                                                                                                                              ^
  <stdin>:6:591: note: possible intended match here
   "/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1/../../../../bin/riscv64-unknown-elf-ld" "--sysroot=/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf" "/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf/lib/crt0.o" "/b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/lib/clang/10.0.0/lib/clang_rt.crtbegin-riscv64.o" "-L/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf/lib" "-L/b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1" "/b/s/w/ir/tmp/t/riscv64-toolchain-ae7410.o" "--start-group" "-lc" "-lgloss" "--end-group" "/b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/lib/clang/10.0.0/lib/libclang_rt.builtins-riscv64.a" "/b/s/w/ir/k/recipe_cleanup/clangeX2xRw/llvm_build_dir/lib/clang/10.0.0/lib/clang_rt.crtend-riscv64.o" "-o" "a.out"

  ... and one more

Could you take a look? Thanks.

Link to error: https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8896884112835419104

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68407/new/

https://reviews.llvm.org/D68407