[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:642
+  }
+  bool mustBeFirstprivateBase(OpenMPDefaultmapClauseModifier M,
+                              OpenMPDefaultmapClauseKind Kind) const {
----------------
Static function


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3092
+            Stack->getDefaultmapModifier(OMPC_DEFAULTMAP_aggregate);
+        OpenMPMapClauseKind Kind = getMapClauseKindFromModifier(Modifier, true);
+        ImplicitMap[Kind].emplace_back(E);
----------------
`true`->`/*Cond=*/true`


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4462
+    unsigned ClauseKindCnt = -1;
+    for (const auto &ImplicitMap : ImplicitMaps) {
+      ++ClauseKindCnt;
----------------
`for (ArrayRef<Expr *> ImplicitMaps: ImplicitMaps)`


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:16420
+    if (M != OMPC_DEFAULTMAP_MODIFIER_tofrom ||
+      Kind != OMPC_DEFAULTMAP_scalar) {
+      std::string Value;
----------------
Not formatted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69204/new/

https://reviews.llvm.org/D69204