[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 12 19:15:43 PST 2019
NoQ marked 2 inline comments as done.
NoQ added inline comments.
================
Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:225
<array>
- <integer>14</integer>
- <integer>16</integer>
- <integer>17</integer>
+ <integer>26</integer>
+ <integer>30</integer>
----------------
`26` is the new `10`.
================
Comment at: clang/test/Analysis/nullability-notes.m:31
-(void) method {
+ clang_analyzer_warnOnDeadSymbol(self);
// no-crash
----------------
D68108 caused this symbol to never die because in the inlined stack frame of the accessor it was bound to implicit parameter variable `self` in the Store, and that variable was put into `UnknownSpaceRegion` due to not being part of its stack frame's declaration, so it was held alive forever by the Store as if it's a static variable.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70158/new/
https://reviews.llvm.org/D70158
More information about the cfe-commits
mailing list