[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 12 18:17:50 PST 2019


dblaikie added a comment.

So I /think/ what's happening here is the extra addresses needed for the call_site low_pcs are creating new basic blocks (or whatever the logic is in the backend that says "use line zero at the start of each basic block-like thing" - possible that logic is overly conservative even though we just labeled something without ever needing to jump to it - guess we could test that with plain scopes).

Now, the test we have internally might be brittle & depending on an accidental source location - and/or this has shown an upstream bug where we drop a location that we should be preserving somewhere along the way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69970/new/

https://reviews.llvm.org/D69970





More information about the cfe-commits mailing list