[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

[Ehud Katz via Phabricator via cfe-commits]

ekatz updated this revision to Diff 228860.
ekatz added a comment.

In D69935#1741995 <https://reviews.llvm.org/D69935#1741995>, @uabelho wrote:

> In D69935#1739235 <https://reviews.llvm.org/D69935#1739235>, @dblaikie wrote:
>
> > In D69935#1738273 <https://reviews.llvm.org/D69935#1738273>, @uabelho wrote:
> >
> > > Don't you need to also remove
> > >
> > >   case LinkageSpecDecl::lang_cxx_11:
> > >   case LinkageSpecDecl::lang_cxx_14:
> > >   
> > >
> > > from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp? (added in r372714 / e07376a320d to silence a clang warning).
> > >  I can't see how that code would compile otherwise?
> >
> >
> > +1 to this
>
>
> Did you see the above?


Sorry, I missed that (its from a separate commit). Added to the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69935/new/

https://reviews.llvm.org/D69935

Files:
  clang-tools-extra/modularize/Modularize.cpp
  clang/include/clang/AST/DeclCXX.h
  clang/lib/AST/DeclPrinter.cpp
  clang/lib/AST/JSONNodeDumper.cpp
  clang/lib/AST/TextNodeDumper.cpp
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/lib/Sema/SemaModule.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69935.228860.patch
Type: text/x-patch
Size: 5150 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191112/ce344cd0/attachment-0001.bin>