[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 11 16:55:16 PST 2019
dexonsmith added a comment.
In D69959#1741456 <https://reviews.llvm.org/D69959#1741456>, @rnk wrote:
> What do you think of making `FrontendOptions::Inputs` be a `SmallVector<*, 0>`? It's janky and inconsistent with the rest of that struct, but it seems less invasive in the end.
+1, we use `SmallVector<*,0>` elsewhere to make up for deficiencies in `std::vector`. If you're changing `Inputs`, should you change the rest of the `std::vector`s in that struct for consistency? There isn't really a downside (on the contrary, it saves a word each).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69959/new/
https://reviews.llvm.org/D69959
More information about the cfe-commits
mailing list