[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 11 16:09:40 PST 2019


rnk added a comment.

In D69766#1739060 <https://reviews.llvm.org/D69766#1739060>, @Ericson2314 wrote:

> Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator?


No, uploading to phabricator is enough.

I started to merge this, but I noticed it breaks two tests:

  Failing Tests (2):
    Clang :: Driver/cl-link.c
    Clang :: Driver/fuse-ld.c

I guess this is more of a functional change than I realized. That would need to be investigated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69766/new/

https://reviews.llvm.org/D69766





More information about the cfe-commits mailing list