[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/IR/OpenMPConstants.h:57
+#include "llvm/IR/OpenMPKinds.def"
+  LLVM_MARK_AS_BITMASK_ENUM(0x7FFFFFFF)
+};
----------------
ABataev wrote:
> Why do you use `0x7FFFFFFF` as the largest value?
Because it is a valid upper bound. We don't have all values in OMP_IDENT_FLAG but if you want to come up with a tighter bound, please feel free.


================
Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:49-51
+  default:
+    // Attributes are optional.
+    break;
----------------
ABataev wrote:
> Do you need the `default:` here?
If we want attributes to be optional, then yes. If we say they are mandatory, then not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69785/new/

https://reviews.llvm.org/D69785