[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

I definitely agree with the default being "do nothing", its not just google style, nearly everyone is using a style which is derived from one of these base styles,  that said turning on a const style by default would IMHO be a mistake, the level of churn could be immense.

I do get the concerns over the matching of "lexed" tokens rather than perhaps a semantic analysis could lead to false positives, that's harder to tell without running this over a larger amount of code and then running the unit tests of those projects, I feel the saving grace is the scenarios are limited to where the word `const` can appear in the language and so this should allow us to limit the possible failure scenarios a little.

I just didn't want to do this in clang-tidy, because I find the whole -fix part of clang-tidy unsatisfactory unless i'm dealing with just one checker at a time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764