[PATCH] D69996: [clangd] Fixes colon escaping on Windows
liu hui via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 11 06:14:46 PST 2019
lh123 added a comment.
In D69996#1740412 <https://reviews.llvm.org/D69996#1740412>, @hokein wrote:
> I believe this patch fixes the issue, but we need to update the file `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations correctly" is diverged from the actual code, although it is still passed (both `string` and `vscode.Uri` have the `toString` method unfortunately).
>
> @lh123 do you mind doing that?
Sorry, I forgot to update the test case, I have submitted a new patch. D70078 <https://reviews.llvm.org/D70078>
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69996/new/
https://reviews.llvm.org/D69996
More information about the cfe-commits
mailing list