[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 9 07:27:46 PST 2019


aaron.ballman added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6860
     "lambda declared 'noreturn' should not return">;
   def warn_maybe_falloff_nonvoid_lambda : Warning<
+    "non-void lambda does not return a value in all control paths">,
----------------
xbolva00 wrote:
> aaron.ballman wrote:
> > And maybe move these two up closer to the other duplicate-ish diagnostics.
> This is in
> "let CategoryName = "Lambda Issue" in {"
> 
> so I am not sure if should really move it.
I hadn't noticed that, let's leave it here. Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69762/new/

https://reviews.llvm.org/D69762





More information about the cfe-commits mailing list