[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 8 17:27:01 PST 2019


arphaman updated this revision to Diff 228548.
arphaman marked 2 inline comments as done.
arphaman retitled this revision from "[WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros" to "[clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros".
arphaman added a comment.

I figured out what I was doing wrong in the tests, and fixed them. This is no longer WIP and is ready for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69543/new/

https://reviews.llvm.org/D69543

Files:
  clang-tools-extra/clangd/ParsedAST.h
  clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt
  clang-tools-extra/clangd/refactor/tweaks/ObjCLocalizeStringLiteral.cpp
  clang-tools-extra/clangd/unittests/TweakTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69543.228548.patch
Type: text/x-patch
Size: 5439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191109/63cafb7e/attachment.bin>


More information about the cfe-commits mailing list