[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

Elizabeth Andrews via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 8 11:21:30 PST 2019


eandrews added a comment.

@rnk @gribozavr2 clang-tidy test "bugprone-string-integer-assignment.cpp" caused a bot fail on windows. From the logs it looks like the 'CHECK-FIXES' I added in that test is failing because the fix isn't applied. I am not sure why. I don't have a windows build set up and I assume a new build is going to take some time. I am not sure what the protocol for this is. Should I go ahead and revert my patch while I investigate the issue on Windows or should I just push a new patch deleting the 'CHECK-FIXES' while I look into the issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69950/new/

https://reviews.llvm.org/D69950





More information about the cfe-commits mailing list