[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 7 17:14:20 PST 2019


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks again!~

In D68162#1705928 <https://reviews.llvm.org/D68162#1705928>, @Szelethus wrote:

> I guess you two are right. Maybe the best solution would be collapse `const CallExpr *` and `AllocationFamily` parameters into `CallEvent`, and just query the relevant information. Sure, its a query every time we need it, but nothing impacts performance as much as months of hair pulling trying to understand what this file does :^)


Just make sure not to store call events in the program state, 'cause they're short-lived :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68162/new/

https://reviews.llvm.org/D68162





More information about the cfe-commits mailing list