[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added a comment.

It was said Clang does not have to match gcc 1:1.

Just because someone uses weird patterns and instead of using pragma push/pop diagnostic in his/her code, should we really change it in Clang?

You should provide extra flag which controls this specific behaviour (and on by default) so user can use it to disable only this specific case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58896/new/

https://reviews.llvm.org/D58896